Re: [PATCH] efi: make unexported efi_rci2_sysfs_init static

From: Ard Biesheuvel
Date: Wed Sep 25 2019 - 11:20:57 EST


On Wed, 25 Sep 2019 at 15:12, Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> wrote:
>
> The efi_rci2_sysfs_init() is not used outside of rci2-table.c so
> make it static to silence the following sparse warning:
>
> drivers/firmware/efi/rci2-table.c:79:12: warning: symbol 'efi_rci2_sysfs_init' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> ---
> drivers/firmware/efi/rci2-table.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/rci2-table.c b/drivers/firmware/efi/rci2-table.c
> index 3e290f96620a..76b0c354a027 100644
> --- a/drivers/firmware/efi/rci2-table.c
> +++ b/drivers/firmware/efi/rci2-table.c
> @@ -76,7 +76,7 @@ static u16 checksum(void)
> return chksum;
> }
>
> -int __init efi_rci2_sysfs_init(void)
> +static int __init efi_rci2_sysfs_init(void)
> {
> struct kobject *tables_kobj;
> int ret = -ENOMEM;
> --
> 2.23.0
>

Thanks Ben.

Queued in efi/urgent