Re: [PATCH] iwlwifi: fix a potential NULL pointer dereference

From: Allen
Date: Thu Sep 19 2019 - 11:30:12 EST




+ trans_pcie->rba.alloc_wq = alloc_workqueue("rb_allocator",
+ WQ_HIGHPRI | WQ_UNBOUND, 1);
+ if (!trans_pcie->rba.alloc_wq) {

I would like to stick to if(unlikely(!trans_pcie->rba.alloc_wq) just
for consistency.

That's just clutter, this path gets called exactly once in the lifetime
of most systems ...

Let me know if I could add your SOB and send out V2.

No no, I've already sent the patch on the way internally :)

Great. Thank you.