Re: [PATCH 2/3] arm64: dts: imx8mm: Use correct clock for usdhc's ipg clk

From: Schrempf Frieder
Date: Thu Sep 19 2019 - 06:04:46 EST


Hi Anson,

On 19.09.19 11:31, Anson Huang wrote:
> Hi, Schrempf
>
>> Hi Anson,
>>
>> I have a question, that is not directly related to this patch.
>> I see that for the usdhc1 and usdhc3 nodes, there is an 'assigned-clock'
>> and 'assigned-clock-rates' property but not for usdhc2. The same applies to
>> the mx8mq and mx8mn dtsi file.
>>
>> Is there any reason for this? If not can you fix it?
>
> This patch series is NOT related to 'assigned-clock' or 'assigned-clock-rates'
> property,

That's exactly what I'm saying. To not cause more confusion, I have sent
a message in a new thread:
http://lists.infradead.org/pipermail/linux-arm-kernel/2019-September/681426.html

> it is just for correcting clock source according to reference manual,
> the 'ipg' clock is from system's IPG_ROOT clock according to reference manual CCM
> chapter, using DUMMY clock is NOT a good option, the 'ipg' clock is supposed
> to be the clock for accessing register, and it should NOT be DUMMY if we know
> what exactly the clock source is used.

That's probably right and I didn't mean to question the patch at all.

Thanks,
Frieder