Re: [PATCH] x86/mm: Remove set_pages_x() and set_pages_nx()

From: Christoph Hellwig
Date: Wed Sep 18 2019 - 16:56:22 EST


On Wed, Sep 18, 2019 at 01:17:13PM -0500, Larry Finger wrote:
> The external module is vboxdrv, which is part of VirtualBox. The setting of
> pages to be executable appears to have been added in kernel 2.4.20.
>
> I am now testing with the former calls to set_pages_x() and set_pages_nx()
> disabled. Thus far, VMs seem to be running OK. I will contact Oracle to
> discuss the matter with them and see if there is some special case that
> requires this facility. If there is one, then they will need to discuss it
> with you and Christoph.

Well, in this case the API is called /dev/kvm. There is really
absolutely no reason for anyone badly reinventing the low-level
VT and SVM code when they can just use the kernel kvm support, which
already has at least half a dozen users.