Re: [Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code

[Jarkko Sakkinen]

On Tue, Sep 17, 2019 at 09:14:15PM +0300, Jarkko Sakkinen wrote:
> On Mon, Sep 16, 2019 at 04:04:24PM +0530, Sumit Garg wrote:
> > Move TPM2 trusted keys code to trusted keys subsystem. The reason
> > being it's better to consolidate all the trusted keys code to a single
> > location so that it can be maintained sanely.
> > 
> > Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> > Signed-off-by: Sumit Garg <sumit.garg@xxxxxxxxxx>
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> 
> This commit has couple of issues that I only noticed when looking into
> bug reported by Mimi.
> 
> Right now tpm_send() is the exported function that is used by other
> subsystems. tpm_transmit_cmd() is an internal function. This commit adds
> two unrelated code paths to send TPM commands, which is unacceptable.
> 
> You should make tpm2 functionality to use tpm_send() instead and remove
> tpm_seal_trusted() and tpm_unseal_trusted() completely in this commit.

The consequence is that the result needs unfortunately re-review. Sorry
about that, just took this time to notice this glitch.

/Jarkko