Re: [PATCH] nvmem: core: fix nvmem_cell_write inline function

From: Srinivas Kandagatla
Date: Tue Sep 17 2019 - 04:20:58 EST




On 17/09/2019 08:57, Arnd Bergmann wrote:
On Mon, Sep 9, 2019 at 3:45 PM Sebastian Reichel <sre@xxxxxxxxxx> wrote:

From: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

nvmem_cell_write's buf argument uses different types based on
the configuration of CONFIG_NVMEM. The function prototype for
enabled NVMEM uses 'void *' type, but the static dummy function
for disabled NVMEM uses 'const char *' instead. Fix the different
behaviour by always expecting a 'void *' typed buf argument.

Fixes: 7a78a7f7695b ("power: reset: nvmem-reboot-mode: use NVMEM as reboot mode write interface")
Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Cc: Han Nandor <nandor.han@xxxxxxxxxxx>
Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx
Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

I still see the issue in linux-next, did this get dropped by accident?


I just pushed it to nvmem tree, should be fixed in next soon!

--srini
Arnd