Re: [PATCH v3 0/3] null_blk: fixes around nr_devices and log improvements

From: Jens Axboe
Date: Mon Sep 16 2019 - 10:56:02 EST


On 9/16/19 8:07 AM, Andrà Almeida wrote:
> Hello,
>
> This patch series address feedback for a previous patch series sent by
> me "docs: block: null_blk: enhance document style"[1].
>
> First patch removes a restriction that prevents null_blk to load with
> (nr_devices == 0). This restriction breaks applications, so it's a bug. I
> have tested it running the kernel with `null_blk.nr_devices=0`.
>
> In the previous series I have changed the type of var nr_devices, but I
> forgot to change the type at module_param(). The second patch fix that.
>
> The third patch uses a cleaver approach to make log messages consistent
> using pr_fmt and the last one add a note on how to do that at the
> coding style documentation.

Applied, thanks.

--
Jens Axboe