Re: [PATCH net-next] net: dsa: b53: Add support for port_egress_floods callback

From: Andrew Lunn
Date: Sat Sep 14 2019 - 11:23:44 EST


On Thu, Sep 12, 2019 at 08:28:39PM -0700, Florian Fainelli wrote:
> Add support for configuring the per-port egress flooding control for
> both Unicast and Multicast traffic.
>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> ---
> Beneditk,
>
> Do you mind re-testing, or confirming that this patch that I sent much
> earlier does work correctly for you? Thanks!
>
> drivers/net/dsa/b53/b53_common.c | 33 ++++++++++++++++++++++++++++++++
> drivers/net/dsa/b53/b53_priv.h | 2 ++
> 2 files changed, 35 insertions(+)
>
> diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
> index 7d328a5f0161..ac2ec08a652b 100644
> --- a/drivers/net/dsa/b53/b53_common.c
> +++ b/drivers/net/dsa/b53/b53_common.c
> @@ -342,6 +342,13 @@ static void b53_set_forwarding(struct b53_device *dev, int enable)
> b53_read8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, &mgmt);
> mgmt |= B53_MII_DUMB_FWDG_EN;
> b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, mgmt);
> +
> + /* Look at B53_UC_FWD_EN and B53_MC_FWD_EN to decide whether
> + * frames should be flooed or not.

Hi Florian

s/flooed/flooded

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew