Re: [PATCH 2/4] arm64: Kconfig: Fix BRCMSTB driver dependencies

From: Arnd Bergmann
Date: Thu Sep 12 2019 - 05:20:59 EST


On Thu, Sep 12, 2019 at 12:19 AM Amit Kucheria <amit.kucheria@xxxxxxxxxx> wrote:
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index 1851112ccc29..d80e8d70bf10 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -22,6 +22,7 @@ config ARM_CCI400_PORT_CTRL
>
> config BRCMSTB_GISB_ARB
> bool "Broadcom STB GISB bus arbiter"
> + depends on ARCH_BRCMSTB
> depends on ARM || ARM64 || MIPS
> default ARCH_BRCMSTB || BMIPS_GENERIC
> help

This breaks MIPS configurations that need this driver, and
it breask compile-testing on non-ARM/MIPS targets.

> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 651b763f80cd..6f0b1ed1a05a 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -59,6 +59,7 @@ config POWER_RESET_BRCMKONA
>
> config POWER_RESET_BRCMSTB
> bool "Broadcom STB reset driver"
> + depends on ARCH_BRCMSTB
> depends on ARM || ARM64 || MIPS || COMPILE_TEST
> depends on MFD_SYSCON
> default ARCH_BRCMSTB || BMIPS_GENERIC

Same here and below.

> diff --git a/drivers/soc/bcm/Kconfig b/drivers/soc/bcm/Kconfig
> index 648e32693b7e..5a8ff33241ae 100644
> --- a/drivers/soc/bcm/Kconfig
> +++ b/drivers/soc/bcm/Kconfig
> @@ -24,6 +24,7 @@ config RASPBERRYPI_POWER
>
> config SOC_BRCMSTB
> bool "Broadcom STB SoC drivers"
> + depends on ARCH_BRCMSTB
> depends on ARM || ARM64 || BMIPS_GENERIC || COMPILE_TEST
> select SOC_BUS
> help

Arnd