Re: [PATCH] bpf: validate bpf_func when BPF_JIT is enabled

From: BjÃrn TÃpel
Date: Wed Sep 11 2019 - 06:39:14 EST



On 2019-09-11 09:42, Yonghong Song wrote:
I am not an expert in XDP testing. Toke, BjÃrn, could you give some
suggestions what to test for XDP performance here?

I ran the "xdp_rxq_info" sample with and without Sami's patch:

$ sudo ./xdp_rxq_info --dev enp134s0f0 --action XDP_DROP

Before:

Running XDP on dev:enp134s0f0 (ifindex:6) action:XDP_DROP options:no_touch
XDP stats CPU pps issue-pps
XDP-RX CPU 20 23923874 0
XDP-RX CPU total 23923874

RXQ stats RXQ:CPU pps issue-pps
rx_queue_index 20:20 23923878 0
rx_queue_index 20:sum 23923878

After Sami's patch:

Running XDP on dev:enp134s0f0 (ifindex:6) action:XDP_DROP options:no_touch
XDP stats CPU pps issue-pps
XDP-RX CPU 20 22998700 0
XDP-RX CPU total 22998700

RXQ stats RXQ:CPU pps issue-pps
rx_queue_index 20:20 22998705 0
rx_queue_index 20:sum 22998705


So, roughly ~4% for this somewhat naive scenario.


As for XDP performance tests; I guess some of the XDP selftests could be
used as well!


BjÃrn