Re: [PATCH] NTB: ntb_transport: remove redundant assignment to rc

From: Jon Mason
Date: Tue Sep 10 2019 - 13:02:37 EST


On Sun, Aug 18, 2019 at 7:53 PM Colin King <colin.king@xxxxxxxxxxxxx> wrote:
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Variable rc is initialized to a value that is never read and it
> is re-assigned later. The initialization is redundant and can be
> removed.

Applied to ntb-next, thanks

> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/ntb/ntb_transport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index 40c90ca10729..00a5d5764993 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -292,7 +292,7 @@ static int ntb_transport_bus_match(struct device *dev,
> static int ntb_transport_bus_probe(struct device *dev)
> {
> const struct ntb_transport_client *client;
> - int rc = -EINVAL;
> + int rc;
>
> get_device(dev);
>
> --
> 2.20.1
>