Re: staging: exfat: issue with FFS_MEDIAERR error return assignment

From: Dan Carpenter
Date: Tue Sep 10 2019 - 09:09:50 EST


On Tue, Sep 10, 2019 at 01:58:35PM +0100, Colin Ian King wrote:
> On 10/09/2019 13:44, Dan Carpenter wrote:
> > On Fri, Aug 30, 2019 at 07:38:00PM +0100, Colin Ian King wrote:
> >> Hi,
> >>
> >> Static analysis on exfat with Coverity has picked up an assignment of
> >> FFS_MEDIAERR that gets over-written:
> >>
> >>
> >> 1750 if (is_dir) {
> >> 1751 if ((fid->dir.dir == p_fs->root_dir) &&
> >> 1752 (fid->entry == -1)) {
> >> 1753 if (p_fs->dev_ejected)
> >
> > Idealy we would have both a filename and a function name but this email
> > doesn't have either so no one knows what code you are talking about. :P
>
> Oops, my bad.
>
> drivers/staging/exfat/exfat_super.c ffsWriteStat()

Yes, your solution is correct.

regards,
dan carpenter