Re: [PATCH 4/5] mm, slab_common: Make 'type' is enum kmalloc_cache_type

From: Vlastimil Babka
Date: Mon Sep 09 2019 - 11:08:42 EST


On 9/3/19 6:04 PM, Pengfei Li wrote:
The 'type' of the function new_kmalloc_cache should be
enum kmalloc_cache_type instead of int, so correct it.

OK

Signed-off-by: Pengfei Li <lpf.vector@xxxxxxxxx>

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

---
mm/slab_common.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/slab_common.c b/mm/slab_common.c
index 8b542cfcc4f2..af45b5278fdc 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -1192,7 +1192,7 @@ void __init setup_kmalloc_cache_index_table(void)
}
static void __init
-new_kmalloc_cache(int idx, int type, slab_flags_t flags)
+new_kmalloc_cache(int idx, enum kmalloc_cache_type type, slab_flags_t flags)
{
if (type == KMALLOC_RECLAIM)
flags |= SLAB_RECLAIM_ACCOUNT;
@@ -1210,7 +1210,8 @@ new_kmalloc_cache(int idx, int type, slab_flags_t flags)
*/
void __init create_kmalloc_caches(slab_flags_t flags)
{
- int i, type;
+ int i;
+ enum kmalloc_cache_type type;
for (type = KMALLOC_NORMAL; type <= KMALLOC_RECLAIM; type++) {
for (i = KMALLOC_SHIFT_LOW; i <= KMALLOC_SHIFT_HIGH; i++) {