Re: [PATCH v2 3/3] staging: exfat: add millisecond support

From: Valentin VidiÄ
Date: Sun Sep 08 2019 - 12:51:36 EST


On Sun, Sep 08, 2019 at 05:40:40PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Sep 08, 2019 at 04:10:15PM +0000, Valentin Vidic wrote:
> > void fat_set_entry_time(struct dentry_t *p_entry, struct timestamp_t *tp,
> > u8 mode)
> > {
> > + u8 ms;
> > u16 t, d;
> > struct dos_dentry_t *ep = (struct dos_dentry_t *)p_entry;
> >
> > t = (tp->hour << 11) | (tp->min << 5) | (tp->sec >> 1);
> > d = (tp->year << 9) | (tp->mon << 5) | tp->day;
> >
> > + ms = tp->millisec;
> > + if (tp->sec & 1) {
> > + ms += 1000;
> > + }
>
> checkpatch didn't complain about this { } not being needed?
>
> Same in other parts of this patch, please fix up.

No warnings from checkpatch here, will update the code.

--
Valentin