Re: [PATCH] kunit: add PRINTK dependency

From: Brendan Higgins
Date: Fri Sep 06 2019 - 20:44:18 EST


On Fri, Sep 6, 2019 at 9:08 AM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On 9/6/19 10:02 AM, Arnd Bergmann wrote:
> > On Fri, Sep 6, 2019 at 5:39 PM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> >>> config KUNIT
> >>> bool "Enable support for unit tests (KUnit)"
> >>> + depends on PRINTK
> >>> help
> >>> Enables support for kernel unit tests (KUnit), a lightweight unit
> >>> testing and mocking framework for the Linux kernel. These tests are
> >>>
> >>
> >> Hi Arnd,
> >>
> >> This is found and fixed already. I am just about to apply Berndan's
> >> patch that fixes this dependency. All of this vprintk_emit() stuff
> >> is redone.
> >
> > Ok, perfect. Unfortunately I only started testing the coming
> > linux-next release after Stephen went on his break, so
> > I'm missing some updates.
> >
>
> No worries. I am pushing it now - should be there in 5-10 mins.
>
> Please use linuxk-kselftest next.
>
> Let me know if you see any issues. Thanks for testing it.

Hi Arnd, Shuah accepted my version of the fix earlier today.
Nevertheless, I really appreciate you looking into this. Sorry for
wasting your time.

Please let me know if you run into any additional issues.

Thanks!