Re: [PATCH] drm/panfrost: Fix regulator_get_optional() misuse

From: Steven Price
Date: Fri Sep 06 2019 - 11:23:30 EST


On 04/09/2019 13:30, Mark Brown wrote:
> The panfrost driver requests a supply using regulator_get_optional()
> but both the name of the supply and the usage pattern suggest that it is
> being used for the main power for the device and is not at all optional
> for the device for function, there is no meaningful handling for absent
> supplies. Such regulators should use the vanilla regulator_get()
> interface, it will ensure that even if a supply is not described in the
> system integration one will be provided in software.
>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

Tested-by: Steven Price <steven.price@xxxxxxx>

Looks like my approach to this was wrong - so we should also revert the
changes I made previously.

----8<----