Re: [PATCH v2 2/2] PTP: add support for one-shot output

From: Richard Cochran
Date: Fri Sep 06 2019 - 01:37:47 EST


On Thu, Sep 05, 2019 at 01:03:46PM +0300, Felipe Balbi wrote:
> This a bit confusing, really. Specially when the comment right above
> those flags states:
>
> /* PTP_xxx bits, for the flags field within the request structures. */

Agreed, it is confusing. Go ahead and remove this comment.

> Seems like we will, at least, make it clear which flags are valid for
> which request structures.

Yes, please do make it as clear as you can.

Thanks,
Richard