Re: [PATCH 0/2] trace-vmscan-postprocess: fix parsing and output

From: Daniel Jordan
Date: Thu Sep 05 2019 - 11:27:29 EST


On Thu, Sep 05, 2019 at 12:32:49PM +0800, Yafang Shao wrote:
> On Thu, Sep 5, 2019 at 4:42 AM Daniel Jordan <daniel.m.jordan@xxxxxxxxxx> wrote:
> > I wonder if we shouldn't just get rid of the whole script, it's hard to
> > remember to keep in sync with vmscan changes and I can't think of a way to
> > remedy that short of having mm regression tests that run this.
>
> There are some similar scripts under tools/perf/scripts/, i.e.
> compaction-times.py.
> What about intergrating these vmscan scripts into perf/scripts as well ?
> Something like vmscan-times.py...

Could be done, but I don't see how that makes it easier to keep in
sync...unless perf's tests are run regularly.