Re: [PATCH v2 2/6] lib/zstd/mem.h: replace __inline by inline

[Miguel Ojeda]

On Thu, Sep 5, 2019 at 2:00 AM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote:
>
> While you're here, would you mind replacing `__attribute__((unused))`
> with `__unused`?  I would consider "naked attributes" (haven't been
> feature tested in include/linux/compiler_attributes.h and are verbose)
> to be an antipattern.

+1 We should aim to avoid them entirely where possible.

We have __always_unused and __maybe_unused, please choose whatever
fits best (both map to "unused", we don't have __unused).

Cheers,
Miguel