Re: [PATCH v3] trace:Add "gfp_t" support in synthetic_events

From: Steven Rostedt
Date: Wed Sep 04 2019 - 12:59:34 EST


On Wed, 04 Sep 2019 08:13:58 -0500
Tom Zanussi <zanussi@xxxxxxxxxx> wrote:

> Hi Steve,
>
> On Wed, 2019-09-04 at 06:43 -0400, Steven Rostedt wrote:
> > On Fri, 12 Jul 2019 11:05:06 -0500
> > Tom Zanussi <zanussi@xxxxxxxxxx> wrote:
> >
> > > Hi Zhengjun,
> > >
> > > On Fri, 2019-07-12 at 09:53 +0800, Zhengjun Xing wrote:
> > > > Add "gfp_t" support in synthetic_events, then the "gfp_t" type
> > > > parameter in some functions can be traced.
> > > >
> > > > Prints the gfp flags as hex in addition to the human-readable
> > > > flag
> > > > string. Example output:
> > > >
> > > > whoopsie-630 [000] ...1 78.969452: testevent: bar=b20
> > > > (GFP_ATOMIC|__GFP_ZERO)
> > > > rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20
> > > > (GFP_ATOMIC)
> > > > rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20
> > > > (GFP_ATOMIC)
> > > >
> > > > Signed-off-by: Tom Zanussi <zanussi@xxxxxxxxxx>
> >
> > Why is this Signed-off-by Tom? Tom, did you author part of this??
> >
>
> Yeah, I added the part that prints the flag names.
>

OK, I'll comment that in the patch change log.

Thanks!

-- Steve