Re: linux-next: build failure after merge of the hmm tree

[Dan Williams]

On Mon, Sep 2, 2019 at 10:42 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Dan,
>
> On Mon, 2 Sep 2019 22:31:00 -0700 Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> >
> > On Mon, Sep 2, 2019 at 4:45 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> > >
> > > Hi Jason,
> > >
> > > On Mon, 2 Sep 2019 10:51:41 +0000 Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote:
> > > >
> > > > On Mon, Sep 02, 2019 at 08:50:17PM +1000, Stephen Rothwell wrote:
> > > >
> > > > > ERROR: "nd_region_provider_data" [drivers/acpi/nfit/nfit.ko] undefined!
> > > > > ERROR: "to_nd_blk_region" [drivers/acpi/nfit/nfit.ko] undefined!
> > > > > ERROR: "nvdimm_region_notify" [drivers/acpi/nfit/nfit.ko] undefined!
> > > > > ERROR: "nvdimm_blk_region_create" [drivers/acpi/nfit/nfit.ko] undefined!
> > > > >
> > > > > Caused by commit
> > > > >
> > > > >   126470c8a58b ("libnvdimm: Enable unit test infrastructure compile checks")
> > > > >
> > > > > I have reverted that commit for today.
> > > >
> > > > Looks like more kconfig trouble, can you send Dan your kconfig? I'll
> > > > drop this patch again
> > > >
> > >
> > > Thanks.  It was just an x86_64 allmodconfig build.  I don't actually
> > > have the .config file (it gets cleaned up, sorry).
> >
> > Strange. x86_64 allmodconfig is certainly a 0day build target. Could
> > this be toolchain dependent?
>
> Possible, I guess.  I am cross compiling on a PowerPC LE host
>
> $ x86_64-linux-gnu-gcc --version
> x86_64-linux-gnu-gcc (Debian 9.2.1-4) 9.2.1 20190821
>
> $ x86_64-linux-gnu-ld --version
> GNU ld (GNU Binutils for Debian) 2.32.51.20190821
>
> It could also be an interaction with something else in linux-next.

I was able to reproduce and it seems to be fixed with this change:

diff --git a/drivers/nvdimm/Makefile b/drivers/nvdimm/Makefile
index 6557e126892f..29203f3d3069 100644
--- a/drivers/nvdimm/Makefile
+++ b/drivers/nvdimm/Makefile
@@ -32,4 +32,4 @@ libnvdimm-$(CONFIG_NVDIMM_KEYS) += security.o

 TOOLS := ../../tools
 TEST_SRC := $(TOOLS)/testing/nvdimm/test
-obj-$(CONFIG_NVDIMM_TEST_BUILD) := $(TEST_SRC)/iomap.o
+obj-$(CONFIG_NVDIMM_TEST_BUILD) += $(TEST_SRC)/iomap.o

I'll send it through one more 0day run before asking Jason to try again.