Re: [PATCH 1/6] usb/ohci-sm501: remove the HCD_DMA flag

From: Guenter Roeck
Date: Tue Sep 03 2019 - 07:37:57 EST


On Tue, Sep 03, 2019 at 10:46:10AM +0200, Christoph Hellwig wrote:
> This driver doesn't support normal DMA, only direct access to its
> local memory. Remove the HCD_DMA flag to properly express that fact.
>
> Fixes: 1e4946c4412e ("usb: add a HCD_DMA flag instead of guestimating DMA capabilities")
> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

on top of next-20190903.

Thanks!

Guenter

> ---
> drivers/usb/host/ohci-sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-sm501.c b/drivers/usb/host/ohci-sm501.c
> index 0b2aea6e28d4..c158cda9e4b9 100644
> --- a/drivers/usb/host/ohci-sm501.c
> +++ b/drivers/usb/host/ohci-sm501.c
> @@ -49,7 +49,7 @@ static const struct hc_driver ohci_sm501_hc_driver = {
> * generic hardware linkage
> */
> .irq = ohci_irq,
> - .flags = HCD_USB11 | HCD_DMA | HCD_MEMORY,
> + .flags = HCD_USB11 | HCD_MEMORY,
>
> /*
> * basic lifecycle operations
> --
> 2.20.1
>