Re: [PATCH v3 4/4] edac: Add support for Amazon's Annapurna Labs L2 EDAC

From: Robert Richter
Date: Tue Sep 03 2019 - 03:27:32 EST


On 15.07.19 16:24:09, Hanna Hawa wrote:
> Adds support for Amazon's Annapurna Labs L2 EDAC driver to detect and
> report L2 errors.
>
> Signed-off-by: Hanna Hawa <hhhawa@xxxxxxxxxx>
> ---
> MAINTAINERS | 6 ++
> drivers/edac/Kconfig | 8 ++
> drivers/edac/Makefile | 1 +
> drivers/edac/al_l2_edac.c | 187 ++++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 202 insertions(+)
> create mode 100644 drivers/edac/al_l2_edac.c

>From a brief look at it, it seems some of my comments from 2/4 apply
here too. Please look through it.

-Robert