Re: [PATCH 2/3] pagewalk: separate function pointers from iterator data

From: Christoph Hellwig
Date: Mon Sep 02 2019 - 03:59:05 EST


On Mon, Sep 02, 2019 at 05:51:58AM +0000, Jason Gunthorpe wrote:
> On Sun, Sep 01, 2019 at 01:35:16PM -0700, Guenter Roeck wrote:
> > > I belive the macros above are missing brackets.. Can you confirm the
> > > below takes care of things? I'll add a patch if so
> > >
> >
> > Good catch. Yes, that fixes the build problem.
>
> I added this to the hmm tree to fix it:

This looks good. Although I still haven't figure out how this is
related to the pagewalk changes to start with..