Re: [PATCH 01/15] sched: introduce task_se_h_load helper

From: Rik van Riel
Date: Fri Aug 23 2019 - 20:05:34 EST


On Fri, 2019-08-23 at 20:13 +0200, Dietmar Eggemann wrote:
>
>
> > @@ -1668,7 +1668,7 @@ static void task_numa_compare(struct
> > task_numa_env *env,
> > /*
> > * In the overloaded case, try and keep the load balanced.
> > */
> > - load = task_h_load(env->p) - task_h_load(cur);
> > + load = task_se_h_load(env->p->se) - task_se_h_load(cur->se);
>
> Shouldn't this be:
>
> load = task_se_h_load(&env->p->se) - task_se_h_load(&cur->se);

Yes indeed. Sorry I forgot to fix these after you
pointed them out last time.

They are now fixed in my tree.

--
All Rights Reversed.

Attachment: signature.asc
Description: This is a digitally signed message part