+void intel_shutdown(struct snd_pcm_substream *substream,
+ÂÂÂÂÂÂÂÂÂÂÂ struct snd_soc_dai *dai)
+{
+ÂÂÂ struct sdw_cdns_dma_data *dma;
+
+ÂÂÂ dma = snd_soc_dai_get_dma_data(dai, substream);
+ÂÂÂ if (!dma)
+ÂÂÂÂÂÂÂ return;
+
+ÂÂÂ snd_soc_dai_set_dma_data(dai, substream, NULL);
+ÂÂÂ kfree(dma);
+}
Correct me if I'm wrong, but do we really need to _get_dma_ here?
_set_dma_ seems bulletproof, same for kfree.
I must admit I have no idea why we have a reference to DMAs here, this looks
like an abuse to store a dai-specific context, and the initial test looks
like copy-paste to detect invalid configs, as done in other callbacks. Vinod
and Sanyog might have more history than me here.
I dont see snd_soc_dai_set_dma_data() call for
sdw_cdns_dma_data so somthing is missing (at least in upstream code)
IIRC we should have a snd_soc_dai_set_dma_data() in alloc or some
initialization routine and we free it here.. Sanyog?
Vinod, I double-checked that we do not indeed have a call to
snd_soc_dai_dma_data(), but there is code in cdns_set_stream() that sets the
relevant dai->playback/capture_dma_data, see below
I am not a big fan of this code, touching the ASoC core internal fields
isn't a good idea in general.
IIRC as long as you stick to single link I do not see this required. The
question comes into picture when we have multi links as you would need
to allocate a soundwire stream and set that for all the sdw DAIs
So, what is the current model of soundwire stream, which entity allocates
that and do you still care about multi-link? is there any machine driver
with soundwire upstream yet?