Re: [PATCH v1 5/5] pinctrl: mediatek: Add support for pin configuration dump via sysfs.

From: Linus Walleij
Date: Fri Aug 23 2019 - 03:52:52 EST


Hi Light,

thanks for your patch!

On Tue, Aug 13, 2019 at 10:53 AM Light Hsieh <light.hsieh@xxxxxxxxxxxx> wrote:

> From: Light Hsieh <light.hsieh@xxxxxxxxxxxx>
>
> Add support for pin configuration dump via catting
> /sys/kernel/debug/pinctrl/$platform_dependent_path/pinconf-pins.

This is debugfs so rename the subject "*debugfs"

> pinctrl framework had already support such dump. This patch implement the
> operation function pointer to fullfill this dump.

Fair enough, that's fine.

> Change-Id: Ib59212eb47febcd84140cbf84e1bd7286769beb0

This has been remarked on before.

This patch is missing your Signed-off-by, please fix that.

Yours,
Linus Walleij