Re: [PATCH 6/9] dm crypt: support diskcipher
From: boojin.kim
Date: Fri Aug 23 2019 - 00:20:54 EST
On Wed, Aug 21, 2019 at 17:19:41PM +0900, Herbert Xu wrote:
> On Wed, Aug 21, 2019 at 04:57:41PM +0900, boojin.kim wrote:
> >
> > Can you tell me which patch you mentioned? Is this?
> > https://patches.linaro.org/project/linux-crypto/list/?series=22762
> >
>
> Yes this is the one.
>
> Cheers,
I looked at ESSIV patch-set.
Can you please confirm that you mean:
'Register FMP as the template of skcipher instead of diskcipher,
and simplify the interface for FMP user'
If yes, I think the following API needs to be added to skcipher:
- _set(): BIO submitter (dm-crypt, f2fs, ext4) sets cipher to BIO.
- _mergeable(): Block layer checks if two BIOs have the same cipher.
- _get(): Storage driver gets cipher from BIO.
- _set_crypt(): Storage driver gets crypto information from cipher and
writes it on the descriptor of Storage controller.
Is it acceptable to skcipher ?