Re: [PATCH] mm/memcg: return value of the function mem_cgroup_from_css() is not checked

From: Michal Hocko
Date: Thu Aug 22 2019 - 16:12:05 EST


On Thu 22-08-19 13:07:17, Yizhuo Zhai wrote:
> This will happen if variable "wb->memcg_css" is NULL. This case is reported
> by our analysis tool.

Does your tool report the particular call path and conditions when that
happen? Or is it just a "it mignt happen" kinda thing?

> Since the function mem_cgroup_wb_domain() is visible to the global, we
> cannot control caller's behavior.

I am sorry but I do not understand what is this supposed to mean.
--
Michal Hocko
SUSE Labs