Re: [PATCH] soc: imx: gpcv2: Print the correct error code

[Daniel Baluta]

On Wed, 2019-08-21 at 18:33 +0200, Guido GÃnther wrote:
> The current code prints 'ret' (thus 0) while it should use 'err'.
> 
> Signed-off-by: Guido GÃnther <agx@xxxxxxxxxxx>

Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxx>

> ---
>  drivers/soc/imx/gpcv2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index 31b8d002d855..b0dffb06c05d 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -198,7 +198,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct
> generic_pm_domain *genpd,
>  		err = regulator_disable(domain->regulator);
>  		if (err)
>  			dev_err(domain->dev,
> -				"failed to disable regulator: %d\n",
> ret);
> +				"failed to disable regulator: %d\n",
> err);
>  		/* Preserve earlier error code */
>  		ret = ret ?: err;
>  	}