Re: [PATCH net] net: dsa: bcm_sf2: Do not configure PHYLINK on CPU port

From: David Miller
Date: Wed Aug 21 2019 - 23:35:47 EST


From: Florian Fainelli <f.fainelli@xxxxxxxxx>
Date: Wed, 21 Aug 2019 17:07:46 -0700

> The SF2 binding does not specify that the CPU port should have
> properties mandatory for successfully instantiating a PHYLINK object. As
> such, there will be missing properties (including fixed-link) and when
> attempting to validate and later configure link modes, we will have an
> incorrect set of parameters (interface, speed, duplex).
>
> Simply prevent the CPU port from being configured through PHYLINK since
> bcm_sf2_imp_setup() takes care of that already.
>
> Fixes: 0e27921816ad ("net: dsa: Use PHYLINK for the CPU/DSA ports")
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Applied, thanks Florian.