Re: [PATCH] cpufreq: Print driver name if cpufreq_suspend() fails

[Viresh Kumar]

On 21-08-19, 16:16, Florian Fainelli wrote:
> Instead of printing the policy, which is incidentally a kernel pointer,
> so with limited interest, print the cpufreq driver name that failed to
> be suspend, which is more useful for debugging.
> 
> Fixes: 2f0aea936360 ("cpufreq: suspend governors on system suspend/hibernate")

I will drop this tag as this isn't a bug really.

> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> ---
>  drivers/cpufreq/cpufreq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index c28ebf2810f1..330d789f81fc 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1807,8 +1807,8 @@ void cpufreq_suspend(void)
>  		}
>  
>  		if (cpufreq_driver->suspend && cpufreq_driver->suspend(policy))
> -			pr_err("%s: Failed to suspend driver: %p\n", __func__,
> -				policy);
> +			pr_err("%s: Failed to suspend driver: %s\n", __func__,
> +				cpufreq_driver->name);
>  	}
>  
>  suspend:

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

-- 
viresh