Re: [PATCH net] net: cpsw: fix NULL pointer exception in the probe error path

From: David Miller
Date: Wed Aug 21 2019 - 17:00:17 EST


From: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>
Date: Wed, 21 Aug 2019 16:41:23 +0200

> In certain cases when the probe function fails the error path calls
> cpsw_remove_dt() before calling platform_set_drvdata(). This is an
> issue as cpsw_remove_dt() uses platform_get_drvdata() to retrieve the
> cpsw_common data and leds to a NULL pointer exception. This patches
> fixes it by calling platform_set_drvdata() earlier in the probe.
>
> Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization")
> Reported-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
> Signed-off-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>

Applied and queued up for -stable, thanks.