Re: [PATCH 11/14] arm64: dts: meson-g12a-x96-max: fix compatible

From: Neil Armstrong
Date: Wed Aug 21 2019 - 10:08:12 EST


On 20/08/2019 22:32, Martin Blumenstingl wrote:
> On Wed, Aug 14, 2019 at 4:33 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>>
>> This fixes the following DT schemas check errors:
>> meson-g12a-x96-max.dt.yaml: /: compatible: ['amediatech,x96-max', 'amlogic,u200', 'amlogic,g12a'] is not valid under any of the given schemas
>>
>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>
> [...]
>> - compatible = "amediatech,x96-max", "amlogic,u200", "amlogic,g12a";
>> + compatible = "amediatech,x96-max", "amlogic,g12a";
> only partially related: I wonder if we should add a s905x2 compatible
> string here and to the .dts filename (just like we separate the GXL
> variants s905x, s905d, s905w, ...)
>

We could, but AFAIK no variants of G12A are planned yet...

Neil