Re: [PATCH net-next] net: stmmac: dwmac-meson8b: use devm_platform_ioremap_resource() to simplify code

[Neil Armstrong]

On 21/08/2019 15:51, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
> 
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> index 786ca4a..9cda29e 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
> @@ -308,7 +308,6 @@ static int meson8b_dwmac_probe(struct platform_device *pdev)
>  {
>  	struct plat_stmmacenet_data *plat_dat;
>  	struct stmmac_resources stmmac_res;
> -	struct resource *res;
>  	struct meson8b_dwmac *dwmac;
>  	int ret;
>  
> @@ -332,8 +331,7 @@ static int meson8b_dwmac_probe(struct platform_device *pdev)
>  		ret = -EINVAL;
>  		goto err_remove_config_dt;
>  	}
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -	dwmac->regs = devm_ioremap_resource(&pdev->dev, res);
> +	dwmac->regs = devm_platform_ioremap_resource(pdev, 1);
>  	if (IS_ERR(dwmac->regs)) {
>  		ret = PTR_ERR(dwmac->regs);
>  		goto err_remove_config_dt;
> 

Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>