Re: [PATCH v2 02/12] powerpc/ps3: replace __ioremap() by ioremap_prot()

From: Christoph Hellwig
Date: Tue Aug 20 2019 - 18:24:16 EST


On Tue, Aug 20, 2019 at 02:07:10PM +0000, Christophe Leroy wrote:
> __ioremap() is similar to ioremap_prot() except that ioremap_prot()
> does a few sanity changes in addition.
>
> The flags used by PS3 are not impacted by those changes so for
> PS3 both functions are equivalent.
>
> At the same time, drop parts of the comment that have been invalid
> since commit e58e87adc8bf ("powerpc/mm: Update _PAGE_KERNEL_RO")
>
> Suggested-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>