Re: [PATCH] input: misc: soc_button_array: use platform_device_register_resndata()

[Enrico Weigelt, metux IT consult]

On 29.07.19 19:23, Dmitry Torokhov wrote:

Hi,

> I wonder if we should pass &pdev->dev instead of NULL here to form
> proper device hierarchy, now that we have this option.

good point, thanks, fixed in v2.


> > +		"gpio-keys",
> > +		PLATFORM_DEVID_AUTO,
> > +		NULL,
> > +		0,
> > +		gpio_keys_pdata,
> > +		sizeof(*gpio_keys_pdata));
> > +
> > +	if (IS_ERR(pd)) {
> > +		dev_err(&pdev->dev, "failed registering gpio-keys: %ld\n", PTR_ERR(pd));
> >   		goto err_free_mem;
>
> Since you did not assign 'error' value here this goto will result in the
> function returning 0 even if platform_device_register_resndata() failed.

Uh, thanks. IMHO it's even worse: 'error' could be uninitialized.


I'm sending v2 separately.


Thanks for your review.

--mtx

--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287