Re: [PATCH 10/22] arm64: dts: qcom: pm8150b: Add pon and adc nodes

From: Stephen Boyd
Date: Mon Aug 19 2019 - 13:56:31 EST


Quoting Vinod Koul (2019-08-19 10:43:31)
> On 14-08-19, 10:08, Stephen Boyd wrote:
> >
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> > > index c0a678b0f159..846197bd65cd 100644
> > > --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> > > @@ -2,6 +2,7 @@
> > > // Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.
> > > // Copyright (c) 2019, Linaro Limited
> > >
> > > +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> > > #include <dt-bindings/interrupt-controller/irq.h>
> > > #include <dt-bindings/spmi/spmi.h>
> > >
> > > @@ -11,6 +12,59 @@
> > > reg = <0x2 SPMI_USID>;
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > > +
> > > + pon@800 {
> >
> > Maybe pon node name should be 'key' or 'power-on'?
>
> pon stands for power on device. See Documentation/devicetree/bindings/power/reset/qcom,pon.txt
>

Right. I was hoping for a more standard node name vs. an acronym that's
SoC specific.