Re: [PULL REQUEST] Please pull rdma.git

From: Jason Gunthorpe
Date: Mon Aug 19 2019 - 08:14:05 EST


On Mon, Aug 19, 2019 at 12:08:16PM +0200, Geert Uytterhoeven wrote:
> Hi Doug, Bernard,
>
> On Wed, Aug 14, 2019 at 5:00 PM Doug Ledford <dledford@xxxxxxxxxx> wrote:
> > Fairly small pull request for -rc3. I'm out of town the rest of this
> > week, so I made sure to clean out as much as possible from patchworks in
> > enough time for 0-day to chew through it (Yay! for 0-day being back
> > online! :-)). Jason might send through any emergency stuff that could
> > pop up, otherwise I'm back next week.
> >
> > The only real thing of note is the siw ABI change. Since we just merged
> > siw *this* release, there are no prior kernel releases to maintain
> > kernel ABI with. I told Bernard that if there is anything else about
> > the siw ABI he thinks he might want to change before it goes set in
> > stone, he should get it in ASAP. The siw module was around for several
> > years outside the kernel tree, and it had to be revamped considerably
> > for inclusion upstream, so we are making no attempts to be backward
> > compatible with the out of tree version. Once 5.3 is actually released,
> > we will have our baseline ABI to maintain.
>
> [...]
>
> > - Allow siw to be built on 32bit arches (siw, ABI change, but OK since
> > siw was just merged this merge window and there is no prior released
> > kernel to maintain compatibility with and we also updated the
> > rdma-core user space package to match)
>
> > Bernard Metzler (1):
> > RDMA/siw: Change CQ flags from 64->32 bits
>
> Obviously none of this was ever compiled for a 32-bit platform?!?

It is puzzling that 0-day or anyone testing linux-next hasn't noticed
this in that last 7 weeks are so..

Jason