Re: [PATCH v2] m68k/mac: Revisit floppy disc controller base addresses

[Geert Uytterhoeven]

On Mon, Jul 8, 2019 at 11:34 AM Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
> Rename floppy_type macros to make them more consistent with the scsi_type
> macros, which are named after classes of models with similar memory maps.
>
> The MAC_FLOPPY_OLD symbol is introduced to change the relevant base
> address from 0x50F00000 to 0x50000000 (consistent with MAC_SCSI_OLD).
>
> The documentation for LC-class machines has the IO devices at offsets
> from $50F00000. Use these addresses for MAC_FLOPPY_LC (consistent with
> MAC_SCSI_LC) because they may not be aliased elsewhere in the memory map.
>
> Add comments with controller type information from 'Designing Cards and
> Drivers for the Macintosh Family', relevant Developer Notes and
> http://mess.redump.net/mess/driver_info/mac_technical_notes
>
> Adopt phys_addr_t to avoid type casts.
>
> Cc: Laurent Vivier <lvivier@xxxxxxxxxx>
> Cc: Joshua Thompson <funaho@xxxxxxxxx>
> Tested-by: Stan Johnson <userm57@xxxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
> Acked-by: Laurent Vivier <lvivier@xxxxxxxxxx>

Thanks, applied and queued for v5,4.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds