Re: [PATCH 1/2] livepatch: Nullify obj->mod in klp_module_coming()'s error path

From: Petr Mladek
Date: Mon Aug 19 2019 - 07:26:28 EST


On Sun 2019-07-28 14:45:33, Josh Poimboeuf wrote:
> On Fri, Jul 19, 2019 at 02:28:39PM +0200, Miroslav Benes wrote:
> > klp_module_coming() is called for every module appearing in the system.
> > It sets obj->mod to a patched module for klp_object obj. Unfortunately
> > it leaves it set even if an error happens later in the function and the
> > patched module is not allowed to be loaded.
> >
> > klp_is_object_loaded() uses obj->mod variable and could currently give a
> > wrong return value. The bug is probably harmless as of now.
> >
> > Signed-off-by: Miroslav Benes <mbenes@xxxxxxx>
> > Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
>
> Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

This patch has been committed into the branch for-5.4/core.

Best Regards,
Petr