Re: [PATCH 08/26] m68k: simplify ioremap_nocache

From: Geert Uytterhoeven
Date: Mon Aug 19 2019 - 04:56:16 EST


Hi Christoph,

On Sat, Aug 17, 2019 at 9:48 AM Christoph Hellwig <hch@xxxxxx> wrote:
> Just define ioremap_nocache to ioremap instead of duplicating the
> inline. Also defined ioremap_uc in terms of ioremap instead of
> the using a double indirection.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

BTW, shouldn't we get rid of the sole user of ioremap_uc(), too?
Seems to make a difference on x86 only, where it is "strongly uncached"
(whatever that may mean ;-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds