Re: cleanup the walk_page_range interface

From: Stephen Rothwell
Date: Sat Aug 17 2019 - 02:42:50 EST


Hi all,

On Fri, 16 Aug 2019 14:06:23 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, 16 Aug 2019 14:32:58 +0200 Christoph Hellwig <hch@xxxxxx> wrote:
>
> > On Fri, Aug 16, 2019 at 11:57:40AM +0000, Jason Gunthorpe wrote:
> > > Are there conflicts with trees other than hmm?
> > >
> > > We can put it on a topic branch and merge to hmm to resolve. If hmm
> > > has problems then send the topic on its own?
> >
> > I see two new walk_page_range user in linux-next related to MADV_COLD
> > support (which probably really should use walk_range_vma), and then
> > there is the series from Steven, which hasn't been merged yet.
>
> Would it be practical to create a brand new interface with different
> functions names all in new source files? Once all callers are migrated
> over and tested, remove the old code?

I certainly prefer that method of API change :-)
(see the current "keys: Replace uid/gid/perm permissions checking with
an ACL" in linux-next and the (currently) three merge fixup patches I
am carrying. Its not bad when people provide the fixes, but I am no
expert in most areas of the kernel ...)
--
Cheers,
Stephen Rothwell

Attachment: pgp5erbe3X7cY.pgp
Description: OpenPGP digital signature