Re: [PATCH 1/1] dt-bindings: power/supply/sbs_sbs-battery: Addition of force_load binding Add device tree binding documentation for addition of force_load boolean value to allow loading a battery during boot even if not present at that time.

From: Rob Herring
Date: Fri Aug 16 2019 - 17:14:34 EST


On Thu, Jul 25, 2019 at 02:50:45PM +0800, Richard Tresidder wrote:
> Signed-off-by: Richard Tresidder <rtresidd@xxxxxxxxxxxxxxxxx>
> ---
>
> Notes:
> Add device tree binding documentation for addition of force_load
> boolean value to allow loading a battery during boot even if not
> present at that time.
> Accompanying patch to drivers/power/supply/sbs-battery.c submitted to linux-pm@xxxxxxxxxxxxxxx
>
> Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> index 4e78e51..187d7bb 100644
> --- a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> @@ -15,7 +15,8 @@ Optional properties :
> after an external change notification.
> - sbs,battery-detect-gpios : The gpio which signals battery detection and
> a flag specifying its polarity.
> -
> + - sbs,force-load : Allow loading of a hot-pluggable battery when there is no
> + GPIO detect available and the module is statically built.

What's a module? That's Linux specific and nothing to do with the
binding.

Can't you just force load if sbs,battery-detect-gpios is not present?

Rob