Re: [PATCH] irqchip/irq-ingenic-tcu: Fix COMPILE_TEST building
From: Thomas Gleixner
Date: Fri Aug 16 2019 - 16:45:25 EST
On Fri, 16 Aug 2019, Paul Burton wrote:
> On Fri, Aug 16, 2019 at 02:28:42PM +0200, Thomas Gleixner wrote:
> > On Tue, 13 Aug 2019, YueHaibing wrote:
> >
> > > While do COMPILE_TEST building, if GENERIC_IRQ_CHIP is
> > > not selected, it fails:
> > >
> > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_intc_cascade':
> > > irq-ingenic-tcu.c:(.text+0x13f): undefined reference to `irq_get_domain_generic_chip'
> > > drivers/irqchip/irq-ingenic-tcu.o: In function `ingenic_tcu_irq_init':
> > > irq-ingenic-tcu.c:(.init.text+0x97): undefined reference to `irq_generic_chip_ops'
> > > irq-ingenic-tcu.c:(.init.text+0xdd): undefined reference to `__irq_alloc_domain_generic_chips'
> > > irq-ingenic-tcu.c:(.init.text+0x10b): undefined reference to `irq_get_domain_generic_chip'
> > >
> > > select GENERIC_IRQ_CHIP to fix this.
> > >
> > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > > Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver")
> >
> > git show 9536eba03ec7
> >
> > fatal: ambiguous argument '9536eba03ec7': unknown revision or path not in
> > the working tree.
>
> The referenced patch is in mips-next - can I get your Ack to apply this
> there too?
Sure. Acked-by-me :)