Re: [v3 1/2] dt/bindings: display: Add optional property node for Mali DP500

From: Rob Herring
Date: Fri Aug 16 2019 - 16:09:31 EST


On Fri, Aug 16, 2019 at 4:14 AM Wen He <wen.he_1@xxxxxxx> wrote:
>
> Add optional property node 'arm,malidp-arqos-value' for the Mali DP500.
> This property describe the ARQoS levels of DP500's QoS signaling.
>
> Signed-off-by: Wen He <wen.he_1@xxxxxxx>
> ---
> change in v3:
> - correction the describe of the node
>
> Documentation/devicetree/bindings/display/arm,malidp.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/arm,malidp.txt b/Documentation/devicetree/bindings/display/arm,malidp.txt
> index 2f7870983ef1..1f711d32f235 100644
> --- a/Documentation/devicetree/bindings/display/arm,malidp.txt
> +++ b/Documentation/devicetree/bindings/display/arm,malidp.txt
> @@ -37,6 +37,8 @@ Optional properties:
> Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt)
> to be used for the framebuffer; if not present, the framebuffer may
> be located anywhere in memory.
> + - arm,malidp-arqos-high-level: phandle to describing the ARQoS levels of DP500's
> + QoS signaling.

The driver is reading a u32... Did you test this?


>
>
> Example:
> @@ -54,6 +56,7 @@ Example:
> clocks = <&oscclk2>, <&fpgaosc0>, <&fpgaosc1>, <&fpgaosc1>;
> clock-names = "pxlclk", "mclk", "aclk", "pclk";
> arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> + arm,malidp-arqos-high-level = <&rqosvalue>;
> port {
> dp0_output: endpoint {
> remote-endpoint = <&tda998x_2_input>;
> --
> 2.17.1
>