Re: [PATCHv2] mm/migrate: clean up useless code in migrate_vma_collect_pmd()

From: Pingfan Liu
Date: Fri Aug 16 2019 - 09:21:18 EST


On Thu, Aug 15, 2019 at 03:40:21PM -0400, Jerome Glisse wrote:
> On Thu, Aug 15, 2019 at 12:23:44PM -0700, Ralph Campbell wrote:
> [...]
> >
> > I don't understand. The only use of "pfn" I see is in the "else"
> > clause above where it is set just before using it.
>
> Ok i managed to confuse myself with mpfn and probably with old
> version of the code. Sorry for reading too quickly. Can we move
> unsigned long pfn; into the else { branch so that there is no
> more confusion to its scope.
Looks better, I will update v3.

Thanks,
Pingfan