Re: [PATCH v3 1/3] clocksource/drivers/renesas-ostm: Use DIV_ROUND_CLOSEST() helper

From: Simon Horman
Date: Fri Aug 16 2019 - 08:58:36 EST


On Wed, Aug 07, 2019 at 10:46:33AM +0200, Geert Uytterhoeven wrote:
> Use the DIV_ROUND_CLOSEST() helper instead of open-coding the same
> operation.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

> ---
> v3:
> - New.
> ---
> drivers/clocksource/renesas-ostm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/renesas-ostm.c b/drivers/clocksource/renesas-ostm.c
> index 61d5f3b539ce23df..37c39b901bb12b38 100644
> --- a/drivers/clocksource/renesas-ostm.c
> +++ b/drivers/clocksource/renesas-ostm.c
> @@ -221,7 +221,7 @@ static int __init ostm_init(struct device_node *np)
> }
>
> rate = clk_get_rate(ostm_clk);
> - ostm->ticks_per_jiffy = (rate + HZ / 2) / HZ;
> + ostm->ticks_per_jiffy = DIV_ROUND_CLOSEST(rate, HZ);
>
> /*
> * First probed device will be used as system clocksource. Any
> --
> 2.17.1
>