Re: [GIT PULL] xfs: fixes for 5.3-rc5

From: Linus Torvalds
Date: Thu Aug 15 2019 - 17:33:59 EST


On Thu, Aug 15, 2019 at 1:05 PM Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote:
>
> FWIW I've wondered off and on if the VFS syscalls should be generating
> some kind of audit trail when something returns an error message to
> userspace?

I don't think it makes sense for any random errors. ENOENT / EPERM /
EACCES / EISDIR etc are generally part of normal operation and
expected.

Things like actual filesystem corruption is different, but we haven't
really had good patterns for it. And I'd hate to add something like a
test for -EFSCORRUPTED when it's so rare. It makes more sense to do
any special handling when that is actually detected (when you might
want to do other things too, like make the filesystem be read-only or
whatever)

Linus