Re: [PATCH -next] mm/kmemleak: record the current memory pool size

From: Catalin Marinas
Date: Thu Aug 15 2019 - 06:02:21 EST


On Wed, Aug 14, 2019 at 03:07:11PM -0400, Qian Cai wrote:
> The only way to obtain the current memory pool size for a running kernel
> is to check back the kernel config file which is inconvenient. Record it
> in the kernel messages.
>
> Signed-off-by: Qian Cai <cai@xxxxxx>
> ---
> mm/kmemleak.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index b8bbe9ac5472..1f74f8bcb4eb 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -1967,7 +1967,8 @@ static int __init kmemleak_late_init(void)
> mutex_unlock(&scan_mutex);
> }
>
> - pr_info("Kernel memory leak detector initialized\n");
> + pr_info("Kernel memory leak detector initialized (mem pool size: %d)\n",
> + mem_pool_free_count);

I wouldn't actually call it the "memory pool size" as I see the size as
a constant set at config time. What about "memory pool available"?

(even this one is not entirely accurate since we have a
mem_pool_free_list but I expect such list not to have too many elements
at the late_initcall time)

If you change the printed string:

Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>